Don't use <h1> in Uppy markup
#5355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diff output filesdiff --git a/packages/@uppy/audio/lib/PermissionsScreen.js b/packages/@uppy/audio/lib/PermissionsScreen.js
index 06b3ee3..1d2aaa4 100644
--- a/packages/@uppy/audio/lib/PermissionsScreen.js
+++ b/packages/@uppy/audio/lib/PermissionsScreen.js
@@ -13,7 +13,7 @@ export default (props => {
h("div", {
className: "uppy-Audio-permissonsIcon",
}, icon()),
- h("h1", {
+ h("div", {
className: "uppy-Audio-title",
}, hasAudio ? i18n("allowAudioAccessTitle") : i18n("noAudioTitle")),
h("p", null, hasAudio ? i18n("allowAudioAccessDescription") : i18n("noAudioDescription")),
diff --git a/packages/@uppy/webcam/lib/PermissionsScreen.js b/packages/@uppy/webcam/lib/PermissionsScreen.js
index 6f0cbce..fd5afb3 100644
--- a/packages/@uppy/webcam/lib/PermissionsScreen.js
+++ b/packages/@uppy/webcam/lib/PermissionsScreen.js
@@ -13,7 +13,7 @@ export default function PermissionsScreen(_ref) {
h("div", {
className: "uppy-Webcam-permissonsIcon",
}, icon()),
- h("h1", {
+ h("div", {
className: "uppy-Webcam-title",
}, hasCamera ? i18n("allowAccessTitle") : i18n("noCameraTitle")),
h("p", null, hasCamera ? i18n("allowAccessDescription") : i18n("noCameraDescription")), |
aduh95
reviewed
Jul 18, 2024
aduh95
approved these changes
Jul 18, 2024
Murderlon
reviewed
Jul 22, 2024
|
@Murderlon, did you read the discussion above? |
Murderlon
approved these changes
Jul 23, 2024
github-actions bot
added a commit
that referenced
this pull request
Jul 30, 2024
| Package | Version | Package | Version | | -------------------- | ------- | -------------------- | ------- | | @uppy/audio | 2.0.1 | @uppy/status-bar | 4.0.1 | | @uppy/aws-s3 | 4.0.2 | @uppy/store-default | 4.1.0 | | @uppy/compressor | 2.0.1 | @uppy/transloadit | 4.0.1 | | @uppy/core | 4.1.0 | @uppy/utils | 6.0.1 | | @uppy/dashboard | 4.0.2 | @uppy/webcam | 4.0.1 | | @uppy/remote-sources | 2.1.0 | uppy | 4.1.0 | - @uppy/remote-sources: fix options type (Merlijn Vos / #5364) - @uppy/transloadit: do not mark `opts` as mandatory (Antoine du Hamel / #5375) - @uppy/compressor: mark `quality` as optional (Antoine du Hamel / #5374) - @uppy/aws-s3: improve error when `endpoint` is not provided (Antoine du Hamel / #5361) - @uppy/core,@uppy/store-default: export `Store` type (Merlijn Vos / #5373) - @uppy/dashboard: make `toggleAddFilesPanel` args consistent (Evgenia Karunus / #5365) - @uppy/dashboard: Dashboard - convert some files to typescript (Evgenia Karunus / #5359) - @uppy/audio,@uppy/webcam: Don't use `<h1>` in Uppy markup (Evgenia Karunus / #5355) - @uppy/status-bar: GoldenRetriever + `hideUploadButton=true` (Evgenia Karunus / #5350) - meta: Bump docker/build-push-action from 6.3.0 to 6.4.1 (dependabot[bot] / #5360)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR accompanying transloadit/uppy.io#266